Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change into a slicker Card button icon #6638

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Change into a slicker Card button icon #6638

merged 2 commits into from
Apr 2, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Apr 1, 2024

I think the bold "play" icon in the header is really distracting; detracts from the rest of the content. Also, it could make the icon consistent across OS (like #6030)

This changes it to something slicker (from tabler icon) https://tabler.io/icons/icon/chevron-down

image image

@ahuang11 ahuang11 requested a review from philippjfr April 1, 2024 22:15
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.17%. Comparing base (385617b) to head (6b40582).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6638       +/-   ##
===========================================
- Coverage   82.88%   71.17%   -11.71%     
===========================================
  Files         313      313               
  Lines       46132    46132               
===========================================
- Hits        38236    32835     -5401     
- Misses       7896    13297     +5401     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 71.17% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 365bf37 into main Apr 2, 2024
9 of 15 checks passed
@philippjfr philippjfr deleted the card_icon branch April 2, 2024 08:00
ahuang11 added a commit that referenced this pull request Apr 2, 2024
ahuang11 added a commit that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants